pay: Enforce maxdelay for direct channel payments#8740
Merged
cdecker merged 1 commit intoElementsProject:masterfrom Dec 19, 2025
Merged
pay: Enforce maxdelay for direct channel payments#8740cdecker merged 1 commit intoElementsProject:masterfrom
cdecker merged 1 commit intoElementsProject:masterfrom
Conversation
Contributor
|
BTW, our plan is to deprecate pay in favor of xpay.... |
When paying through a direct channel, direct_pay_override() creates a route bypassing the normal routing path, which skips the CLTV budget check in payment_getroute(). This allows payments to succeed even when maxdelay is set below the required min_final_cltv_expiry. Add a check in direct_pay_override() to verify the required CLTV doesn't exceed cltv_budget before using the direct channel shortcut. If it exceeds, skip the direct channel and let normal routing handle the failure with a proper error message. Fixes: ElementsProject#8609 Changelog-Fixed: pay: `maxdelay` parameter now enforced for direct channel payments
wqxoxo
force-pushed
the
fix/issue-8609-pay-maxdelay
branch
from
9c078ce to
b0a4743
Compare
Member
|
ACK b0a4743 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8609
When paying through a direct channel,
direct_pay_override()creates a route bypassing the normal routing path, which skips the CLTV budget check inpayment_getroute(). This allows payments to succeed even when maxdelay is set below the requiredmin_final_cltv_expiry.Add a check in
direct_pay_override()to verify the required CLTV doesn't exceedcltv_budgetbefore using the direct channel shortcut.